London| SDC-Nov-25| Fatma Degirmenci | Sprint 5| Laptop allocation#329
Open
fatmaevin wants to merge 1 commit intoCodeYourFuture:mainfrom
Open
London| SDC-Nov-25| Fatma Degirmenci | Sprint 5| Laptop allocation#329fatmaevin wants to merge 1 commit intoCodeYourFuture:mainfrom
fatmaevin wants to merge 1 commit intoCodeYourFuture:mainfrom
Conversation
fatmaevin
added
Needs Review
illicitonion
added
Complete
|
|
||
| # try all possible laptop combinations | ||
| def find_best_allocation(person_index:int,current_total:int,current_allocation: Dict[Person, Laptop],remaining_laptops: List[Laptop]): | ||
| nonlocal total, allocation |
Member
There was a problem hiding this comment.
We generally avoid nonlocal where-ever possible, because it makes it much harder to reason about code.
Consider instead passing around an object as an argument to this function so it's more clear what's passed where, and what can modify what.
Member
|
This is looking great, well done! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self checklist